Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MetaInfo file #2180

Merged
merged 10 commits into from
Oct 7, 2024
Merged

add MetaInfo file #2180

merged 10 commits into from
Oct 7, 2024

Conversation

jstsmthrgk
Copy link
Contributor

@jstsmthrgk jstsmthrgk commented Oct 1, 2024

  • copied summary from .desktop file
  • copied description from website (left headings out)
  • copied categories from .desktop file
  • took the screenshots from the website, copied captions from website
  • copied description of last release from github

stuff still missing (see https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines):

  • Metadata License, daid must agree that the metadata in this file is under a looser license (is needed for all the aggregation that is done by flathub and such) the guidelines ask for FSFAP or CC0.
  • Content rating, is ships shooting at each other and destroying them violence and in which bucket of OARS does it fall? Also probably "Uncontrolled chat functionality between users" and "Uncontrolled audio or video chat between users" (used Pioneer for reference)

@jstsmthrgk jstsmthrgk marked this pull request as draft October 1, 2024 20:30
@jstsmthrgk jstsmthrgk marked this pull request as ready for review October 1, 2024 20:54
Copy link
Owner

@daid daid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this pull request, I am not sure why this file is needed (I might just be lacking background info)

<summary>Spaceship bridge simulator game</summary>

<!-- of course I just copied the stuff from the website, daid needs to agree first <metadata_license>FSFAP</metadata_license>-->
<project_license>GPL-2.0-only</project_license>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true. Some of the assets are under a closed license.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now having looked at all files with license in their name, I suppose the correct one would be:
GPL-2.0-only AND LicenseRef-TurboSquid-Royalty-Free-License AND OFL-1.1 AND Apache-2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I've changed it to this one now, I hope you find it correct?

io.github.daid.EmptyEpsilon.metainfo.xml Outdated Show resolved Hide resolved
@jstsmthrgk
Copy link
Contributor Author

It is required because else submission to flathub is not possible.

https://docs.flathub.org/docs/for-app-authors/requirements

All submissions must provide a Metainfo file that passes validation.

The file could of course also be hosted somewhere else or maybe even be generated, but I guess it would be easiest to just keep it in here.

@jstsmthrgk
Copy link
Contributor Author

I have also ran the checks, it does complain about the captions for the screenshots being too long, but that is just a warning. (Also it errors on the missing metadata license, but when I uncomment that it passes.)

@daid
Copy link
Owner

daid commented Oct 4, 2024

It is required because else submission to flathub is not possible.

https://docs.flathub.org/docs/for-app-authors/requirements

All submissions must provide a Metainfo file that passes validation.

The file could of course also be hosted somewhere else or maybe even be generated, but I guess it would be easiest to just keep it in here.

I think, it would be better then to have a template file and fill in the details during cmake configure. https://cmake.org/cmake/help/latest/command/configure_file.html can be used for this to fill in things like version numbers. Just like I do for the android manifest: https://github.com/daid/EmptyEpsilon/blob/master/cmake/android/AndroidManifest.xml.in

@daid
Copy link
Owner

daid commented Oct 4, 2024

Oh, and I'm fine for CC0 for the metadata.

@jstsmthrgk
Copy link
Contributor Author

I think, it would be better then to have a template file and fill in the details during cmake configure. https://cmake.org/cmake/help/latest/command/configure_file.html can be used for this to fill in things like version numbers. Just like I do for the android manifest: https://github.com/daid/EmptyEpsilon/blob/master/cmake/android/AndroidManifest.xml.in

way ahead of you, was already done before your comment (although it seems I used a different syntax for the variables)

as the metadata license is now also in there, it should be ready to merge (I think)

@daid daid merged commit e8b519e into daid:master Oct 7, 2024
7 checks passed
Tsht pushed a commit to Tsht/EmptyEpsilon that referenced this pull request Oct 12, 2024
* add MetaInfo file

* install metainfo file

* add oars rating

* move metainfo file to template

* make it a cmake configure template (untested)

* fix a very obvious mistake in CMakeLists.txt

* use correct variables

* fix license in metainfo

* add CC0 as metadata license

---------

Co-authored-by: jstsmthrgk <[email protected]>
Co-authored-by: jstsmthrgk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants