add MetaInfo file #2180
add MetaInfo file #2180
Conversation
| <summary>Spaceship bridge simulator game</summary> | ||
|
|
||
| <!-- of course I just copied the stuff from the website, daid needs to agree first <metadata_license>FSFAP</metadata_license>--> | ||
| <project_license>GPL-2.0-only</project_license> |
There was a problem hiding this comment.
This isn't true. Some of the assets are under a closed license.
There was a problem hiding this comment.
Ok, now having looked at all files with license in their name, I suppose the correct one would be:
GPL-2.0-only AND LicenseRef-TurboSquid-Royalty-Free-License AND OFL-1.1 AND Apache-2.0
There was a problem hiding this comment.
So, I've changed it to this one now, I hope you find it correct?
|
It is required because else submission to flathub is not possible. https://docs.flathub.org/docs/for-app-authors/requirements
The file could of course also be hosted somewhere else or maybe even be generated, but I guess it would be easiest to just keep it in here. |
|
I have also ran the checks, it does complain about the captions for the screenshots being too long, but that is just a warning. (Also it errors on the missing metadata license, but when I uncomment that it passes.) |
I think, it would be better then to have a template file and fill in the details during cmake configure. https://cmake.org/cmake/help/latest/command/configure_file.html can be used for this to fill in things like version numbers. Just like I do for the android manifest: https://github.com/daid/EmptyEpsilon/blob/master/cmake/android/AndroidManifest.xml.in |
|
Oh, and I'm fine for CC0 for the metadata. |
way ahead of you, was already done before your comment (although it seems I used a different syntax for the variables) as the metadata license is now also in there, it should be ready to merge (I think) |
* add MetaInfo file * install metainfo file * add oars rating * move metainfo file to template * make it a cmake configure template (untested) * fix a very obvious mistake in CMakeLists.txt * use correct variables * fix license in metainfo * add CC0 as metadata license --------- Co-authored-by: jstsmthrgk <[email protected]> Co-authored-by: jstsmthrgk <[email protected]>
.desktopfile.desktopfilestuff still missing (see https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines):